ReSharper is smarter than me
time to read 1 min | 110 words

Given the following block of code:

if (presenter.GetServerUrlFromRequest!=null)
	GetServerUrlFromRequest.Checked = presenter.GetServerUrlFromRequest.Value;
else
	GetServerUrlFromRequest.Checked = true;

Resharper gave me the following advice:

image

And turned the code to this piece:

GetServerUrlFromRequest.Checked = !(presenter.GetServerUrlFromRequest!=null) || 
                                  presenter.GetServerUrlFromRequest.Value;

And while it has the same semantics, I actually had to dechiper the code to figure out what it was doing.

I choose to keep the old version.

0 comments
Tags:

Related posts that you may find interesting:

07 Apr 2011 Refactoring toward frictionless & odorless code: Hiding global state
NHibernate
06 May 2010 Riddle me this: String outputs
02 Apr 2008 What is wrong with this code? Answers
challenges